Skip to content
This repository has been archived by the owner on Jan 17, 2022. It is now read-only.

Call start tour method from within another component #88

Closed
simonemazzoni opened this issue Aug 31, 2016 · 10 comments
Closed

Call start tour method from within another component #88

simonemazzoni opened this issue Aug 31, 2016 · 10 comments
Assignees

Comments

@simonemazzoni
Copy link

Hello,

I'm trying to create a Tour component to handle tours on my project.

Since angular-intro.js is a directive, I wrapped it inside a component with its own controller plus a service. I made this because I need to fire the start tour method from another component, but since the angular-intro.js directive binds the start method to the $scope in which is placed, theres no way to fire the start tour from another component (since there's not an easy way to access a component scope).

Is there a way to accomplish my task?

Why there's no service exposed for this directive?

@brunomperes
Copy link

I don't see why it isn't a service

@millerscout millerscout self-assigned this Feb 20, 2017
@millerscout
Copy link
Collaborator

i agreed on that, i'll make the changes and i'll be careful about those currently using as directive.

@simonemazzoni
Copy link
Author

Thanks @millerscout!! Let me know when it's done!

@millerscout
Copy link
Collaborator

@simonemazzoni i've finished the service, i'm currently testing on my environment that uses both ways, the service and the directive.

later i'll make the pull-request and update the documentation.

but you'll be able to use on this branch:

https://github.com/millerscout/angular-intro.js/tree/ngintroAsService

@simonemazzoni
Copy link
Author

@millerscout thanks!
I'll have a look at it as soon as I can.
Once tested, could you please also update in on npm?

Thanks

@millerscout
Copy link
Collaborator

@mendhak when it's possible, may you update npm package for the last release?

@mendhak
Copy link
Owner

mendhak commented Mar 4, 2017

So sorry I missed this. It's pushed now.

@millerscout
Copy link
Collaborator

thanks :)

@simonemazzoni there you go.

@simonemazzoni
Copy link
Author

Great! Many thanks ;)

@millerscout
Copy link
Collaborator

Let's close this,

if you need something let us know :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants