Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom URL logging does not support an emailaddress being used for user authentication. #709

Closed
arjenbarnhard opened this issue Jan 10, 2019 · 3 comments
Labels
Milestone

Comments

@arjenbarnhard
Copy link

arjenbarnhard commented Jan 10, 2019

Custom URL
https://user%40example.com:password@fqdn

according to debug log becomes:
https://user%40example.fqdn

@mendhak mendhak added the bug label Jan 19, 2019
@mendhak
Copy link
Owner

mendhak commented Jan 20, 2019

I've changed the regex for username:password checking in 61c3890

It should now allow a custom URL like so

https://user@example.com:mypassword@fqdn/endpoint?lat=%lat%lon=%lon
https://user%40example.com:mypassword@fqdn/endpoint?lat=%lat%lon=%lon

If you are able to sideload APKs you can try:

APK,
signature,
checksum

@mendhak mendhak added this to the v100 milestone Jan 20, 2019
@semperor
Copy link

semperor commented Feb 6, 2019

I installed the APK and checked it. The login was possible when I removed a "#" from my password. 👍

But I will open an new issue for it.

@arjenbarnhard
Copy link
Author

Tested the solution and can confirm this issue is fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants