The build feature cannot be added multiple times

[sferencik]

The TeamCity-Graphite build feature now allows being added multiple times to a single build config; see here. However, practically this does not work. There are multiple places in the code that assume that the feature is enabled at most once, e.g.:

• GraphiteBuildParametersProvider - loops through all the features but if there are multiple Graphite ones, it will probably take the params from the latest
• BuildStatusListener.IsFeatureEnabled()
  • the very question is wrong: the client shouldn't be asking "is the Graphite feature enabled" but "get me the list of Graphite features that are enabled"
  • the response is wrong too: if there are two Graphite features added to a build config, and the first one is disabled, IsFeatureEnabled() will report false (see the break statement) - despite the fact that one of the two features is indeed enabled

To be clear, I don't have a use case for multiple Graphite features per single build config. I just noticed this because I ran into the case described in the last bullet point above: the Graphite feature being ignored because another Graphite feature was disabled.

[sferencik]

As a quick fix, I propose to just own up and say that only one such feature is enabled.