Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More compact source code #11

Open
MengelCode opened this issue Nov 11, 2019 · 18 comments
Open

More compact source code #11

MengelCode opened this issue Nov 11, 2019 · 18 comments
Assignees
@MengelCode
Labels
Potentially unwanted Something is not necessarily a bug, but not optimal

Comments

@MengelCode
Copy link
Owner

MengelCode commented Nov 11, 2019 •
edited

The usage of function variables has been quite overdone at some point. So, before continuing, the object types an own Enemy class could be created for should become the subject to refactoring.
@MengelCode MengelCode added Potentially unwanted Something is not necessarily a bug, but not optimal blocker Prevents another task from being done. labels Nov 11, 2019
@MengelCode MengelCode self-assigned this Nov 11, 2019
@MengelCode MengelCode mentioned this issue Nov 11, 2019
Closed
@MengelCode
Copy link
Owner Author

Refactoring in progress for enemy type "Meteor":

  • Class Meteor created.
  • Level 1 occurences have been adapted.

@MengelCode MengelCode added the in progress Something is being worked on label Nov 15, 2019
@MengelCode
Copy link
Owner Author

Refactoring done for enemy type "Meteor":

  • Level 2 occurrences have been adapted.

@MengelCode
Copy link
Owner Author

Refactoring done for enemy type "Stupid Enemy":

  • Level 1 occurrences have been adapted.
  • Not used in Level 2.

@MengelCode
Copy link
Owner Author

Refactoring for enemy type "Blinky":

  • Level 1 occurrences have been adapted.
  • Level 2 occurrences have been adapted.

@MengelCode
Copy link
Owner Author

General notice: Only the "trivial" occurrences (entries in the spawn list of the level) have been updated so far. No updates as part of objects (aircrafts, projectiles) happened so far.

@MengelCode
Copy link
Owner Author

Refactoring for enemy type "Blinky Tracer":

  • Atomic level 1 occurrences have been adapted.
  • Atomic level 2 occurrences have been adapted,

@MengelCode
Copy link
Owner Author

I think I am done for now. Refactoring can still later be continued for stuff like projectiles.

@MengelCode MengelCode removed blocker Prevents another task from being done. in progress Something is being worked on labels Nov 19, 2019
@MengelCode MengelCode removed their assignment Nov 19, 2019
@MengelCode
Copy link
Owner Author

Blocked by #19

@MengelCode MengelCode added blocked Task cannot be continued due to another task or difficulties to make progress. and removed blocked Task cannot be continued due to another task or difficulties to make progress. labels Dec 26, 2019
@MengelCode
Copy link
Owner Author

Task can be continued now.

@MengelCode
Copy link
Owner Author

I will start to modularize the code into single units of small JavaScript files soon.

@MengelCode MengelCode self-assigned this Sep 3, 2020
@MengelCode MengelCode added in progress Something is being worked on blocker Prevents another task from being done. labels Sep 3, 2020
@MengelCode
Copy link
Owner Author

I should not really change much of the other code before I have put everything into its own files.

@MengelCode
Copy link
Owner Author

I will playtest the refactored code soon. Should no bug become visible hindering it to be merged to master, then at least a big refactoring part can be considered done and small bugs and such can then be fixed based on code with less merge conflict potential.

@MengelCode
Copy link
Owner Author

Looks good to me. I will suspend refactoring with the current intermediate result and merge this into master and roll this out on the website.

@MengelCode MengelCode removed blocker Prevents another task from being done. in progress Something is being worked on labels Sep 21, 2020
@MengelCode
Copy link
Owner Author

MengelCode commented Oct 11, 2020 •
edited

Technical debt I need to take care of after implementing and merging issue #29 :

  • Refactor and simply the rendering of notification boxes.
  • Do the same to the process of input device (re-)registration.

@MengelCode
Copy link
Owner Author

Technical debt I will soon start to clean up:
The complex boss objects and their functions still need to be moved into their own files.

@MengelCode
Copy link
Owner Author

Technical debt I need to care about later:
Level backgrounds should not be objects of the type Enemy - they should either be of Decoration or should even get an own
subclass.

@MengelCode
Copy link
Owner Author

Small code redundancy decrease is pushed now.

@MengelCode MengelCode mentioned this issue Jan 1, 2022
Closed
MengelCode added a commit that referenced this issue Jan 1, 2022
@MengelCode
Refactor code #11 correct year of copyright #132
58a5fa8
@MengelCode
Copy link
Owner Author

All level bosses are now split into their own source code files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MengelCode MengelCode

Labels
Potentially unwanted Something is not necessarily a bug, but not optimal
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@MengelCode