Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Important: Adapt license file. #36

Closed
MengelCode opened this issue Mar 29, 2020 · 8 comments
Closed

Important: Adapt license file. #36

MengelCode opened this issue Mar 29, 2020 · 8 comments
Assignees
Labels
bug Something isn't working done Task is finished elementary A task related to the project schedule / MVP

Comments

@MengelCode
Copy link
Owner

Because the new Docker configuration files are now licensed under a Creative Commons license, the license file is no longer correct.
To prevent too much from going wrong, I think I should freeze all running tasks until I worked this out.

Related:
#20 and #33

@MengelCode MengelCode added bug Something isn't working elementary A task related to the project schedule / MVP blocker Prevents another task from being done. labels Mar 29, 2020
@MengelCode MengelCode self-assigned this Mar 29, 2020
@MengelCode MengelCode added the in progress Something is being worked on label Mar 29, 2020
@MengelCode
Copy link
Owner Author

@ichbestimmtnicht How should I present the Creative Commons you applied in the license file of the repository? What I would do if you were okay with is as follows:

@MengelCode MengelCode assigned MengelCode and unassigned MengelCode Mar 29, 2020
@MengelCode MengelCode added question Further information is requested and removed in progress Something is being worked on labels Mar 29, 2020
@ichbestimmtnicht
Copy link
Contributor

Do as you wish. Except the Dockerfile in your project root every file in the hooks folder has a correct license header that says that the template is from my project and a link to it.

PS: my editor says that your Readme has more 9+ not best practices. (Jumping ## to #### and using html tag that can be done easy within markdown for example) If you like I can change them for you or we go in a phonecall (discord) over them together.

@MengelCode MengelCode added in progress Something is being worked on and removed question Further information is requested labels Mar 29, 2020
@MengelCode
Copy link
Owner Author

MengelCode commented Mar 29, 2020

@ichbestimmtnicht Sounds good for me.
Then, I would suggest that I edit the license file and you edit the readme to reflect the double-licensing and to not violate the style guide anymore.

@ichbestimmtnicht
Copy link
Contributor

I also added some icons to the top
readme.zip

@ichbestimmtnicht
Copy link
Contributor

Note Check line 31. Forgot a new line with a backslash

@MengelCode MengelCode removed the blocker Prevents another task from being done. label Mar 29, 2020
@MengelCode
Copy link
Owner Author

License file corrected in commit e0afcf1.

@MengelCode
Copy link
Owner Author

@ichbestimmtnicht

I corrected the small mistake and applied the new readme in commit ad93234. Thank you for supporting the project by having an eye on it and by offering the Docker facility. I will close this issue and mark it as done, as I am now content with everything here.

@MengelCode MengelCode added done Task is finished and removed in progress Something is being worked on labels Mar 29, 2020
@ichbestimmtnicht
Copy link
Contributor

I saw later that my note was just a personal preference...

Thank you very much.

Repository owner deleted a comment from kuddleofficial Feb 1, 2021
Repository owner deleted a comment from kuddleofficial Feb 1, 2021
Repository owner locked as resolved and limited conversation to collaborators Feb 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working done Task is finished elementary A task related to the project schedule / MVP
Projects
None yet
Development

No branches or pull requests

2 participants