Remove Confederate from color list #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just joined an open source project that's using this and [animals](https://github.com/boennemann/animals/blob/master/words.json) to generate some random titles (ex: ExpeditionPorcupine289, BonanzaAlligator021, etc....) Was confused as hell when I saw  Will admit that it's an accurate color description for #5c6272, but given that so many people likely use this library for so many different things, having "Confederate" in a widely used list of color titles is likely to have some weird unintended consequences. It'd probably be best to just remove.
|
🎉 This PR is included in version 10.2.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
@Dsm0 good catch! Thank you for your contribution. v10.3.0 should be free of confederates https://github.com/meodai/color-names/releases/tag/v10.3.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just joined an open source project that's using this and animals to generate some random titles (ex: ExpeditionPorcupine289, BonanzaAlligator021, etc....)
Was confused as hell when I saw
Will admit that it's an accurate color description for #5c6272, but given that so many people likely use this library for so many different things, having "Confederate" in a widely used list of color titles is likely to have some weird unintended consequences. It'd probably be best to just remove.