This repository has been archived by the owner on Jun 27, 2022. It is now read-only.
Upgrade to 2018 edition #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the interest in the crate and for the update! The changes look good 👍🏼 Alas, a word of warning: this implementation is not production-ready. In particular, the congestion control seems to only be partially compatible with the reference µTP implementation, which may cause stalling and retransmissions at higher transfer rates. |
meqif
approved these changes
May 29, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there!
I'm trying out a project which requires uTP, and I came across your crate - which seems quite complete.
I've updated the code to match Rust 2018 edition, and I thought you could want contributions to update the lib.
cheers!