Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Refactor Drivers to use composition instead of inheritance #187

Closed
LevUdaltsov opened this issue Mar 22, 2024 · 1 comment
Closed
Labels
enhancement New feature or request no-issue-activity

Comments

@LevUdaltsov
Copy link
Contributor

The structure of drivers follows multiple inheritance and the methods each class keep overwriting eachother.

It would be cleaner to have something so that there is one base abstract Base class with get_iter for example and then use composition for other functionality we require

e.g

Inheritance:
Driver --> IterDriver --> MapDriver

Composition:
Driver <-- IterDriver
Driver <-- MapDriver
IterDriver <-- MapDriver

Naming can be changed to be more clear on what entities perform what functions.

This should not affect the driver behaviour

DoD:

  • multiple inheritance for drivers removed
  • mypy tests pas with the 'ignore' tags removed
@LevUdaltsov LevUdaltsov added the enhancement New feature or request label Mar 22, 2024
@LevUdaltsov LevUdaltsov mentioned this issue Mar 22, 2024
Copy link

This is issue is marked as stale as it has been inactive for 30 days. It will be closed in 7 days.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request no-issue-activity
Projects
None yet
Development

No branches or pull requests

1 participant