Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add link for circleci to CI badge #9

Merged
merged 1 commit into from Dec 14, 2018

Conversation

tnir
Copy link
Contributor

@tnir tnir commented Dec 11, 2018

WHAT

This adds link for circleci to CI badge.

WHY

Currently we have a link to the static image.

Signed-off-by: Takuya Noguchi <takninnovationresearch@gmail.com>
@tnir tnir requested a review from tcnksm as a code owner December 11, 2018 06:45
@codecov-io
Copy link

Codecov Report

Merging #9 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@         Coverage Diff          @@
##           master    #9   +/-   ##
====================================
  Coverage      93%   93%           
====================================
  Files           2     2           
  Lines         100   100           
====================================
  Hits           93    93           
  Misses          5     5           
  Partials        2     2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c99239...ca63c78. Read the comment docs.

Copy link
Collaborator

@tcnksm tcnksm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks

@tcnksm tcnksm merged commit c1a7190 into mercari:master Dec 14, 2018
@tnir tnir deleted the add-link-to-circleci branch December 22, 2018 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants