Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set lastSyncTime annotation on Custom Resources #7

Closed
rafalgalaw opened this issue Sep 18, 2023 · 1 comment · Fixed by #49
Closed

Set lastSyncTime annotation on Custom Resources #7

rafalgalaw opened this issue Sep 18, 2023 · 1 comment · Fixed by #49
Assignees
Labels
enhancement New feature or request

Comments

@rafalgalaw
Copy link
Contributor

What steps did you take and what happened?

It would be cool to have a lastSyncTime annotation in our crds. Previously we had such field in our pool.Status which caused countless reconcile loops.

What did you expect to happen?

Set annotation like in the following reference implementation:
kubernetes-sigs/cluster-api

garm version

v0.1.3

garm-operator version

v0.1.0

Kubernetes version

Kubernetes 1.25.5

Anything else you would like to add?

No response

@bavarianbidi
Copy link
Member

I like the idea for having this information reflected back into CR (especially in combination with a custom kube-state-metrics configuration it should be quite easy to expose the last reconciliation Timestamp of the CR via a metric)

@rafalgalaw rafalgalaw self-assigned this Dec 4, 2023
@rafalgalaw rafalgalaw added the enhancement New feature or request label Dec 4, 2023
@rafalgalaw rafalgalaw linked a pull request Jan 9, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants