Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the use of triple colon operators #3

Closed
nanxstats opened this issue May 19, 2022 · 3 comments
Closed

Remove the use of triple colon operators #3

nanxstats opened this issue May 19, 2022 · 3 comments
Assignees

Comments

@nanxstats
Copy link
Collaborator

From the R CMD check, I see

* checking dependencies in R code ... NOTE
Unexported object imported by a ':::' call: ‘r2rtf:::as_rtf_new_page’
  See the note in ?`:::` about the use of this operator.

Since r2rtf:::as_rtf_new_page() is simply defined as:

function () paste("{\\pard\\fs2\\par}\\page{\\pard\\fs2\\par}")

To eliminate the note, you can either 1) export it in r2rtf or 2) copy it as an internal function to this package.

@elong0527
Copy link
Collaborator

I typically handle this issue following https://stackoverflow.com/questions/63023526/unexported-object-imported-by-a-call-tsfeaturesscalets.

I would suggest to address this NOTE while we preparing CRAN submission.

@nanxstats
Copy link
Collaborator Author

I having a mixed feeling about the getFromNamespace() trick mentioned in the SO answer. Feels to me it's not a permanent solution and can be even harmful: it can easily break the package once the upstream private API changes. 🤔

But I do agree this can be handled later when appropriate.

@elong0527
Copy link
Collaborator

The dependency has been removed. Closing the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants