Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sound adjustment with Home Theater #34

Closed
tansuka opened this issue Apr 9, 2018 · 16 comments
Closed

Sound adjustment with Home Theater #34

tansuka opened this issue Apr 9, 2018 · 16 comments
Assignees

Comments

@tansuka
Copy link

tansuka commented Apr 9, 2018

Hello @merdok ,

As mentioned here , it's not possible to control volume if it's an external source connected through arc. It works flawlessly if sound is set to internal speaker but if I use my home theater, add on can't get and set the correct volume level.

Thanks

@merdok
Copy link
Owner

merdok commented Apr 9, 2018

I am not sure if it is possible to control the volume of external sources. I would need to check this out.

@quacktacular
Copy link

quacktacular commented Apr 11, 2018

Just confirming this issue exists over ARC output.

I noticed that the plugin is able to read the current volume. Its also able to mute / unmute.

[2018-4-10 17:23:35] [TVbert] webOS - TV state: On
[2018-4-10 17:23:35] [TVbert] webOS - TV volume: 21
[2018-4-10 17:23:35] [TVbert] webOS - TV muted: No
[2018-4-10 17:23:35] [TVbert] webOS - TV state: On

@quacktacular
Copy link

@merdok I noticed that volume up and down buttons in the LG app work as expcected. If this doesn’t work out would it be easy to add optional volume up and down switches? (Presumably using the API calls those button do)

@tansuka
Copy link
Author

tansuka commented Apr 11, 2018

Hello @quacktacular and @merdok ,

Yes, Mute and unmute work flawlessly, I couldn't get TV Volume level (external source source level) during my tests.
Since Volume up / down work, maybe we can still use brightness slider, iterate within a for loop and until volume is up to desired level send volume up command one by one. But it's crucial to have current volume level of the tv (external source) which I couldn't.

Thanks

@merdok
Copy link
Owner

merdok commented Apr 11, 2018

@quacktacular @tansuka
Thanks for the info. So just to confirm, the issue is that you can't set or get the volume of external audio devices with the current volume switch, but the mute / unmute is working?

@merdok merdok self-assigned this Apr 11, 2018
@quacktacular
Copy link

@merdok yes that is mostly correct.

In my case the plugin actually can read the volume, but just can't set it.

@merdok
Copy link
Owner

merdok commented Apr 11, 2018

Ok. Unfortunately I don't have any external audio device to test it with, but i will see what i can do.

@quacktacular
Copy link

Sounds good. Let me know if I can anything to help. Happy to create a vm on my network for you to try if that would be helpful.

@merdok
Copy link
Owner

merdok commented Apr 11, 2018

Sure, will do that when i need some help. Thanks!

@merdok
Copy link
Owner

merdok commented Jul 8, 2018

Should be possible with latest release, i have added volume up/down switches, could somebody please try it and let me know? Please note that i renamed the package to homebridge-webos-tv, so you need to install this new package and adjust your config.json

@quacktacular
Copy link

@merdok can confirm this is working! and much better than the hack I had written haha.

Can we also get a toggle to disable the lightbulb control?

@merdok
Copy link
Owner

merdok commented Jul 8, 2018

@quacktacular Good to hear :)

I thought of adding a toggle to switch between the lightbulb and those switches, but in the end i decided against it since this would just make the code more complicated, mostly because i would need to handle the mute switch differently. Also i would anyway had to add a 3rd switch for the mute button so why no to use the lightbulb. And finally with the lightbulb you know what the volume of your TV is, useful when you not at home and want to check the volume level.

@merdok merdok closed this as completed Jul 8, 2018
@quacktacular
Copy link

@merdok I totally understand, but I've actually found the volume indicated on the light bulb isn't accurate. Worse when I try to control "all the lights" it always fails because of the volume bulb (which I can't turn off without disabling the new buttons as well).

A boolean for the lightbulb would be enough, myself (and probably others) won't really mind the missing mute capability.

@merdok
Copy link
Owner

merdok commented Jul 20, 2018

Will think about it. Thanks for the feedback!

@merdok
Copy link
Owner

merdok commented Jul 21, 2018

@quacktacular it is now included in the latest release. Let me know if that fits your needs :)

@quacktacular
Copy link

Brilliant! Working great, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants