-
-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sound adjustment with Home Theater #34
Comments
I am not sure if it is possible to control the volume of external sources. I would need to check this out. |
Just confirming this issue exists over ARC output. I noticed that the plugin is able to read the current volume. Its also able to mute / unmute.
|
@merdok I noticed that volume up and down buttons in the LG app work as expcected. If this doesn’t work out would it be easy to add optional volume up and down switches? (Presumably using the API calls those button do) |
Hello @quacktacular and @merdok , Yes, Mute and unmute work flawlessly, I couldn't get TV Volume level (external source source level) during my tests. Thanks |
@quacktacular @tansuka |
@merdok yes that is mostly correct. In my case the plugin actually can read the volume, but just can't set it. |
Ok. Unfortunately I don't have any external audio device to test it with, but i will see what i can do. |
Sounds good. Let me know if I can anything to help. Happy to create a vm on my network for you to try if that would be helpful. |
Sure, will do that when i need some help. Thanks! |
Should be possible with latest release, i have added volume up/down switches, could somebody please try it and let me know? Please note that i renamed the package to |
@merdok can confirm this is working! and much better than the hack I had written haha. Can we also get a toggle to disable the lightbulb control? |
@quacktacular Good to hear :) I thought of adding a toggle to switch between the lightbulb and those switches, but in the end i decided against it since this would just make the code more complicated, mostly because i would need to handle the mute switch differently. Also i would anyway had to add a 3rd switch for the mute button so why no to use the lightbulb. And finally with the lightbulb you know what the volume of your TV is, useful when you not at home and want to check the volume level. |
@merdok I totally understand, but I've actually found the volume indicated on the light bulb isn't accurate. Worse when I try to control "all the lights" it always fails because of the volume bulb (which I can't turn off without disabling the new buttons as well). A boolean for the lightbulb would be enough, myself (and probably others) won't really mind the missing mute capability. |
Will think about it. Thanks for the feedback! |
@quacktacular it is now included in the latest release. Let me know if that fits your needs :) |
Brilliant! Working great, thank you! |
Hello @merdok ,
As mentioned here , it's not possible to control volume if it's an external source connected through arc. It works flawlessly if sound is set to internal speaker but if I use my home theater, add on can't get and set the correct volume level.
Thanks
The text was updated successfully, but these errors were encountered: