New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added getStatus to ScheduledTask #103
Conversation
src/task.js
Outdated
var execution = new Promise(function(resolve, reject){ | ||
self.emit('started', self); | ||
var ex = self.execution(); | ||
if( execution instanceof Promise){ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'Promise' is not defined.
src/task.js
Outdated
console.error(err); | ||
} | ||
var self = this; | ||
var execution = new Promise(function(resolve, reject){ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'Promise' is not defined.
}); | ||
} catch (error) { | ||
console.error(error); | ||
self.emit('failed', error); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'self' used out of scope.
src/scheduled-task.js
Outdated
|
||
ScheduledTask.prototype.getStatus = function() { | ||
return this.status; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing semicolon.
what changed? getStatus() ain't working no more, and i also can't destroy the scheduled task. |
No description provided.