Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review required from members of a Team #236

Closed
JonasHornung opened this issue Nov 15, 2019 · 1 comment · Fixed by #299
Closed

Review required from members of a Team #236

JonasHornung opened this issue Nov 15, 2019 · 1 comment · Fixed by #299
Assignees
Labels
🎉 Feature: planned We will implement this feature but we may not have assigned a milestone yet. 🎉 Feature: requested New feature request from the community. New App Permission needed Mergeable bot doesn't have permission to be able to implement this feature currently 🕑 Waiting

Comments

@JonasHornung
Copy link

Hi,
we have the following situation:
We got two teams with write access to our repository and we'd like to have reviews/approvals of 2 members of the first team and 1 member of the second team to approve a pull-request to be mergeable. We tried some different approaches with mergeable: Insert the Team-Names as reviewers, Insert the team names in the CodeOwners file, but both didn't work (in the second scearnio mergeable didn't finish at all, it was running for almost half an hour).
Do you have any idea how our requirement could be solved using mergeable? Or do you maybe plan to implement to support team-names as required reviewers?

Thanks you very much!

@shine2lay
Copy link
Member

hey @JonasHornung! that is a cool feature request, currently mergeable doesn't know the concept of team member vs regular users. From a quick glance at github api, this is something that can be implemented in mergeable but unfortunately i'll be busy for next month or so. I can try to get to this after that. If you wish to write the feature and submit a PR, i'll do my best to review and get it deployed ASAP.

@shine2lay shine2lay added New App Permission needed Mergeable bot doesn't have permission to be able to implement this feature currently 🎉 Feature: planned We will implement this feature but we may not have assigned a milestone yet. 🎉 Feature: requested New feature request from the community. 🕑 Waiting labels Apr 1, 2020
@shine2lay shine2lay self-assigned this May 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎉 Feature: planned We will implement this feature but we may not have assigned a milestone yet. 🎉 Feature: requested New feature request from the community. New App Permission needed Mergeable bot doesn't have permission to be able to implement this feature currently 🕑 Waiting
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants