Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release & publish docker images with versioning after release is completed #597

Closed
quike opened this issue Nov 13, 2021 · 5 comments · Fixed by #751
Closed

Release & publish docker images with versioning after release is completed #597

quike opened this issue Nov 13, 2021 · 5 comments · Fixed by #751
Labels

Comments

@quike
Copy link
Contributor

quike commented Nov 13, 2021

We are coming from #554

The purpose of the issue would be to build and publish a new docker mergeable image with the new version after the release is completed.
Currently the docker job is ignored and no new builds are published. The idea is to connect both workflows so one follows another one and new artifacts can be deployed to be consumed with the right version.

Besides current Dockerfile is off in comparison of nodejs version used by the app

Dockerfile: FROM node:12.16.0
package.json: 14.15.4

@shine2lay any reason why docker images are not built? github rate limitations?

@shine2lay
Copy link
Member

@quike i am not aware of a blocker to build docker images, we just haven't gotten around to it.

@boekkooi-lengoo
Copy link

@shine2lay are you planning to enable pushing to https://hub.docker.com/r/mergeability/mergeable?
It would be great to have an official build.
Based on .github/workflows/docker.yml it looks like adding the secrets DOCKERHUB_PUSH, DOCKERHUB_USERNAME, DOCKERHUB_PASSWORD and DOCKERHUB_REPO would enable this.

@tenshiAMD
Copy link
Contributor

@boekkooi-lengoo looks like it is purposely disabled by them

@Ch4s3r
Copy link
Contributor

Ch4s3r commented Jun 3, 2024

The issue linked in the docker.yml regarding the workaround does not exist anymore.
Is there a possibility to enable the publishing of docker images again?

Copy link

🎉 This issue has been resolved in version 2.18.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants