Entities: Spy arguments storing refactoring #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merindorium
force-pushed
the
pr-spy-call-refactoring
branch
from
59df4d5
to
1f91d34
Compare
merindorium
changed the title
The current approach of storing call arguments directly in `Spy` is not flexible enough. This commit adds `MethodCall` entity that stores call arguments. Now `Spy` stores an array of method calls. That gives us the ability to count calls out-of-box and now `Spy` stores all calls instead of the last one.
- Add `asSafe` public method that safely casts stored value to expected type. - Remove redundant `cast` method.
Update code examples according to API changes.
merindorium
force-pushed
the
pr-spy-call-refactoring
branch
from
2214191
to
4a20428
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current approach of storing call arguments directly in
Spyis not flexible enough.This PR adds
MethodCallentity that stores call arguments.Now
Spystores an array of method calls. That gives us the ability to count calls out-of-box and nowSpystores all calls instead of the last one.