Missing dist/meriyah.d.ts file

[fisker]

This file is not generated.

[fisker]

Ah, found it, it's in dist/src/meriyah.d.ts, so fix this in package.json ?

https://github.com/meriyah/meriyah/blob/master/package.json#L9-L10

[3cp]

Not sure if this is a regression due to tsc? Let me check old versions.

[3cp]

Looks like a regression.

[3cp]

Oh, it's my code. Caused by export { version } from '../package.json';

[3cp]

This is troublesome for typescript. Do you have any idea how to bypass this issue?

[fisker]

Another thing, this CommentType is not right

meriyah/src/estree.ts

Line 35 in cf8417b

export type CommentType = 'Line' | 'Block' | 'HTMLOpen' | 'HTMLClose';

[3cp]

what's wrong there?

[fisker]

- export type CommentType = 'Line' | 'Block' | 'HTMLOpen' | 'HTMLClose'; 
+ export type CommentType = 'MultiLine' | 'SingleLine' | 'HashbangComment' | 'HTMLOpen' | 'HTMLClose'; 

[3cp]

Right, I am not sure why there is another definition in src/lexer/comments. Should find someway to reuse.

[fisker]

Change estree.ts and import {CommentType} in src/lexer/comments?

[3cp]

@KFlash there is mismatch of type

meriyah/src/estree.ts

Line 35 in cf8417b

export type CommentType = 'Line' | 'Block' | 'HTMLOpen' | 'HTMLClose';

meriyah/src/lexer/comments.ts

Line 14 in eeb0c06

export const CommentTypes = ['SingleLine', 'MultiLine', 'HTMLOpen', 'HTMLClose', 'HashbangComment'];

Any idea how to define once and reuse in both places?

[3cp]

@fisker that CommentType enum in src/lexer/comments is backed by integer, not string.

[3cp]

v3.1.4 is released with updated type path in package.json.

[fisker]

We'll be able to use meriyah in prettier to format .js in next few days, but we don't use JavaScript...:smile:

[KFlash]

@3cp Just change the names in estree.ts ?

[3cp]

Sure. Will do.

[3cp]

Patched in master branch.