Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

package.json path in dist/src/meriyah.d.ts not right #155

Closed
fisker opened this issue Nov 6, 2020 · 3 comments
Closed

package.json path in dist/src/meriyah.d.ts not right #155

fisker opened this issue Nov 6, 2020 · 3 comments

Comments

@fisker
Copy link
Collaborator

fisker commented Nov 6, 2020

Line 7 meriyah/dist/src/meriyah.d.ts, it should be ../../package.json
@fisker fisker mentioned this issue Nov 6, 2020
Closed
@fisker fisker changed the title Bundled package.json path not right package.json path in dist/src/meriyah.d.ts not right Nov 6, 2020
@3cp
Copy link
Member

3cp commented Nov 6, 2020

It's auto generated by tsc.
It refers to dist/package.json (which is also auto generated by tsc as part of the typing), not the root package.json.

@3cp
Copy link
Member

3cp commented Nov 7, 2020

I see what went wrong.

The dist/package.json is only generated by npm run build. The npm run bundle did not generate that file. Investigating.

@3cp 3cp closed this as completed in d267336 Nov 7, 2020
@3cp
Copy link
Member

3cp commented Nov 7, 2020

v3.1.6 is released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fisker @3cp