Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce bundle size by using meriyah.esm.mjs in favor of meriyah.esm.js #236

Open
benmccann opened this issue Feb 24, 2023 · 1 comment
Open

Comments

@benmccann
Copy link
Contributor

Right now there is both a meriyah.esm.js and meriyah.esm.mjs that are distributed. These appear to be the same file:

await copyFile('./dist/meriyah.esm.js', './dist/meriyah.esm.mjs');

Distributing the same file with two different names makes the npm bundle larger whereas if meriyah.esm.mjs were used exclusively the bundle size would be smaller

@3cp
Copy link
Member

3cp commented Feb 24, 2023

When we enabled cjs and mjs files, the js files were kept for backwards compatibility in case users have explicitly used them.

I agree we need to clean the dist files up. But we prefer doing it together with a major version release, that would also allow us to remove more outdated files in current JS lands. For example the systemjs format files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants