Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues using with TypeScript: no exported member 'Errors' #58

Closed
jwhitmarsh opened this issue Nov 13, 2019 · 2 comments
Closed

Issues using with TypeScript: no exported member 'Errors' #58

jwhitmarsh opened this issue Nov 13, 2019 · 2 comments

Comments

@jwhitmarsh
Copy link

jwhitmarsh commented Nov 13, 2019

Firstly, thank you for this excellent lib!

Here's the issue:

node_modules/meriyah/dist/common.d.ts:2:10 -
error TS2305: Module '"../../../../../../../node_modules/meriyah/dist/errors"' 
has no exported member 'Errors'.

2 import { Errors } from './errors';

I think it's because the Errors enum is marked as @internal so it's not making to the dist build, so everything importing Errors is unhappy.

I've solved this by setting skipLibCheck: true in my tsconfig (which might be a good thing to do in any case), but thought it was worth raising in case someone else comes across it.

@KFlash
Copy link
Contributor

KFlash commented Nov 13, 2019

Hi. Glad to hear you liked this lib :) I removed the @internal and pushed a new release to NPM. Let's hope that solves the issue.

@KFlash KFlash closed this as completed in bbfc5c2 Nov 13, 2019
@jwhitmarsh
Copy link
Author

Thanks for the quick response @KFlash, that works now :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants