BigInt

[neumatho]

Hi,

If you using a really big number in hexadecimal format, e.g. this one taken from your unit test 0x12300000000000000000000000000000000n, then the value of the Literal node only get the value of 9 instead of the real number, which is 99022168773993092867842010762644549533696.

I think it is because your doing a parseInt on a number that have exponential included.

The type of the node is also BigIntLiteral, which should only be Literal according to the specification.

-Thomas

[KFlash]

Thanks for this info! This was done by some students of mine. Do you want to do a PR to solve it?

[neumatho]

Well, I was hoping that someone on the Meriyah team will fix it :-)

[KFlash]

cc/ @3cp Any insight in this issue?

[3cp]

My PR didn't change the type BigIntLiteral to Literal. I will double check estree spec.

[neumatho]

Just want to be sure that the changes work. Note that the parser does different things depending if your giving a big number as a normal number or in hexadecimal. I think you may loose precision for hexadecimal. Please double check with the number given above.

-Thomas

[3cp]

Yes, your case is added into the unit tests.

[3cp]

Thomas, the BigIntLiteral is right in the spec, a sub class of Literal. https://github.com/estree/estree/blob/d1cb85c0da029f905d3ef1930cec26d836f9d73f/es2020.md#bigintliteral

[neumatho]

You're right it is a new interface, but the type does not change, like for regex literals: https://github.com/estree/estree/blob/d1cb85c0da029f905d3ef1930cec26d836f9d73f/es5.md#literal. They are also called Literal as type.

If you try a bigint with Acorn on https://astexplorer.net/, then you will see it is also called Literal.

[3cp]

I see, you are right.
We probably need to double check all estree interfaces.

[3cp]

@neumatho pls try v3.0.0.

[3cp]

@neumatho the v3.0.0 was shipped with wrong dist files. Pls try v3.0.1.

[neumatho]

That seems to work.