Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforcement of parameters names #1

Open
vadginz opened this issue Apr 10, 2021 · 1 comment
Open

Enforcement of parameters names #1

vadginz opened this issue Apr 10, 2021 · 1 comment

Comments

@vadginz
Copy link

vadginz commented Apr 10, 2021

Nice idea and implementation :-)

Why to enforce parameters to have the same names like in the interface declaration in method doAllParametersMatch?

if (!(targetParam.Name == callingParam.Name && ...

On my opinion, it's not so clear when you code lambda expression like this:

.Runs<int, string>(numberOfFoos =>

Thanks,
Vadim

@merken
Copy link
Owner

merken commented Apr 10, 2021

Hi,
Thanks for your opinion.

The parameter names constraint is indeed a bit excessive, this code was ported from Prise https://github.com/merken/Prise, where this requirement is bit more strict.

I don't understand the second part of your issue,

On my opinion, it's not so clear when you code lambda expression like this:

.Runs<int, string>(numberOfFoos =>

What is not clear to you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants