Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to customize conventions #18

Closed
marcusds opened this issue Aug 27, 2020 · 10 comments
Closed

Option to customize conventions #18

marcusds opened this issue Aug 27, 2020 · 10 comments

Comments

@marcusds
Copy link

Type of issue

  • Feature request

This plugin is using the getbem.com standard instead of the BEM standard from bem.info (which is from the original creators of BEM), it would nice if the customize the BEM conventions to match what we are targeting. Thanks.

https://en.bem.info/methodology/naming-convention/

@MatheusRich
Copy link

MatheusRich commented Sep 10, 2020

This would be useful for using this package for linting SUIT CSS too. I'd like to use using this convention: MyBlock-myElement--myModifier

@pdaus1405
Copy link

I find this feature also good 👍🏻

@ernscht
Copy link
Member

ernscht commented Jan 8, 2021

Sorry, I've neglected this repo terribly. Thanks for the reminder.
I'll try to take some time this weekend.

@pdaus1405
Copy link

No work? is the package died?

@MatheusRich
Copy link

@pdaus1405 The last commit was dec/2020, I think it's not dead.

@pdaus1405
Copy link

but some comments, wishes and pr's and no movement

@jantimon
Copy link
Contributor

I am using this plugin in multiple projects and it works well.
Adding now tons of option will increase the complexity for configuration and maintenance.

That's the reason why we are cautious to add new options unless they are solving a common problem.

@ernscht
Copy link
Member

ernscht commented Jan 18, 2021

Sorry guys for the late replies. And thanks for the feature request.

In addition to Jan's answer:
As you can see from the examples, we didn't just take over rules, but also extended them. The Linting Tool represents our idea of how the class names should be structured. This has developed over the years.
For example, we decided to only allow lower case letters. On the one hand this is very readable, on the other hand it's easy to lint.

We are aware that this stylelint plugin cannot be used to lint different bem naming conventions, which is why we have decided to publish the package scoped. We want to offer a simple, clear plugin and keep the complexity small to remain maintainable.

Do you know this stylelint plugin stylelint-selector-bem-pattern?
It offers configuration options for different naming conventions. It didn't match our needs, but maybe it goes in the direction you want?

@pdaus1405
Copy link

thank you, i know the plugin.
unfortunately it is dead and can no longer cope with the current stylelint version.

@ernscht
Copy link
Member

ernscht commented Jul 6, 2023

Closing, due to the fact, that this is an optiniated scoped stylelint plugin to follow our idea of how the class names should be structured.
We will not invest additional development time in ideas that generate work for us but add little value. PR's we would of course like to discuss.

@ernscht ernscht closed this as completed Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

5 participants