Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arrow of class diagram inheritance arrow missing #1687

Closed
lfuhr opened this issue Sep 19, 2020 · 13 comments · Fixed by #4788
Closed

Arrow of class diagram inheritance arrow missing #1687

lfuhr opened this issue Sep 19, 2020 · 13 comments · Fixed by #4788
Assignees
Labels
Graph: Class Internals: Parser Status: Approved Is ready to be worked on Type: Enhancement New feature or request Type: New Shape Request for new shape

Comments

@lfuhr
Copy link

lfuhr commented Sep 19, 2020

There are two options.

  • Introduce another arrow like --i> , --[>, --o> or --|:>
  • Change the black arrow --|> to be white

What do you think

@github-actions github-actions bot added the Status: Triage Needs to be verified, categorized, etc label Sep 19, 2020
@WolfgangFahl
Copy link

see #780

@WolfgangFahl
Copy link

see https://en.wikipedia.org/wiki/Class_diagram#/media/File:Uml_classes_en.svg
grafik

@fightinggg
Copy link

There are two options.

  • Introduce another arrow like --i> , --[>, --o> or --|:>
  • Change the black arrow --|> to be white

What do you think

I think so
Inheritance arraow should fill with white color

@wouterbeek
Copy link

wouterbeek commented Aug 29, 2021

+1 Mermaid deviates from most if not all other class diagram visualizations in this regard. It would be great if this could be fixed.

@mvf
Copy link

mvf commented Sep 11, 2021

The arrow should be hollow (i.e. background color, which isn't necessarily white). For now, I'm using the following workaround in my config.json:

{
    "theme": "dark",
    "themeCSS": ".extension { fill: #1c1e1f !important; }"
}

Before:
image

After:
image

Unfortunately, one can't use transparent because then the arrows look like this:
image

It would be great if Realization and Association/Dependency arrows could be fixed too. The former have a dashed outline, and the latter have an unorthodox tented appearance instead of being just two solid lines.

@das-g
Copy link

das-g commented Aug 27, 2022

The arrow should be hollow (i.e. background color, which isn't necessarily white).

Indeed. This is confirmed by https://www.uml-diagrams.org/generalization.html:

A generalization is shown as a line with a hollow triangle as an arrowhead between the symbols representing the involved classifiers. The arrowhead points to the symbol representing the general classifier. […]

[…]

… and by the UML 2.5 specification (PDF, section 9.2.4.2 "Other elements" on p. 100) …

A Generalization is shown as a line with a hollow triangle as an arrowhead between the symbols representing the
involved Classifiers. The arrowhead points to the symbol representing the general Classifier.

… with examples in section 9.2.5 on the following page:

image

@michalspano
Copy link

michalspano commented Oct 20, 2022

Any updates on this one? I like the tool a lot; it's just this inconsistency which makes it harder to use, regarding the solid triangle for inheritance.

@skogsbaer
Copy link

I would really appreciate an fix here. Mermaid is just plain wrong regarding generalization arrows.

@lfuhr
Copy link
Author

lfuhr commented Nov 26, 2022

I think we should make a point what solution developers should go for.

Give me a thumbs up here if you think
--|> should be changed to transparent.

@lfuhr
Copy link
Author

lfuhr commented Nov 26, 2022

Give me a thumbs up here if you think
it would be better to Introduce another arrow like --i> , --[>, --o> or --|:>

@lfuhr
Copy link
Author

lfuhr commented Nov 26, 2022

Give me a thumbs up here if you think
It is just fine as it is

@WolfgangFahl
Copy link

UML sets the standard so i think this could be a way to avoid further discussion:
grafik

@jgreywolf
Copy link
Contributor

No reason to add a new arrow type at this point. Just to correct the arrow being used. I will look at this.

@jgreywolf jgreywolf self-assigned this Mar 16, 2023
@jgreywolf jgreywolf added Status: Approved Is ready to be worked on Graph: Class and removed Status: Triage Needs to be verified, categorized, etc labels Mar 16, 2023
@Yokozuna59 Yokozuna59 added Internals: Parser Type: Enhancement New feature or request Type: New Shape Request for new shape labels Jul 23, 2023
@knsv knsv closed this as completed in #4788 Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Graph: Class Internals: Parser Status: Approved Is ready to be worked on Type: Enhancement New feature or request Type: New Shape Request for new shape
Projects
None yet
10 participants