feat(git): allow custom merge commit ids #3361
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃搼 Summary
Currently, merge commits can have a git tag, but they cannot have a custom git commit ID.
This commit allows modifying the default merge commit id.
Resolves #3356
Partially resolves issue #3238 (most of the discussion there is talking about merge commit IDs, but technically the issue is asking for all merge commits to have all the same options as base commits).
馃搹 Design Decisions
In order to view the custom merge commit ids, I've undone commit 3ccf027.
This means that all merge commits have their IDs displayed, including auto-generated commit IDs. Personally, I think this is okay, since it's how git works, but it does add a bit of clutter to the git graphs.
If you want, I could hide merge commits labels behind a config option
gitGraphConfig.showMergeCommitLabel
.I've also made a commit (aloisklink@954bf9e), where I update some
mermaid-examples
diagrams in the docs, but they're not included in this PR, since the docs currently only use v9.1.5 of mermaid:mermaid/docs/index.html
Lines 21 to 22 in cde3a7c
Example changes:
馃搵 Tasks
Make sure you
develop
branch