Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diagram proposal: 2 x 2 matrix #4282

Closed
tobie opened this issue Apr 6, 2023 · 8 comments · Fixed by #4383
Closed

Diagram proposal: 2 x 2 matrix #4282

tobie opened this issue Apr 6, 2023 · 8 comments · Fixed by #4383

Comments

@tobie
Copy link
Contributor

tobie commented Apr 6, 2023

Proposal

2 x 2 matrices are commonly used to break down complex problems along two key variables.

They can be used to position different options precisely in this matrix, e.g.: Gartner Magic Quadrants come to mind.

Example of a Gartner Magic Quadrant

matrix2x2
    title Gartner Magic Quadrant
    x-axis Completeness of Vision ->
    y-axis Ability to Execute ->
    quadrant I Leaders
    quadrant II Challengers
    quadrant III Niche
    quadrant IV Visionaries
    Microsoft: [0.75, 0.75]
    Salesforce: [0.55, 0.60]
    IBM: [0.51, 0.40]
    Incorta: [0.20, 0.30]

Or they can be more abstract and expose just four concepts covered by those two variables, the Eisenhower Matrix comes to mind:

Example of the Eisenhower Matrix

matrix2x2
    title Eisenhower Matrix
    x-axis Urgent -> Not Urgent
    y-axis Not Important -> Important
    quadrant I Plan
        Some additional text here.
    quadrant II Do
    quadrant III Delegate
    quadrant IV Delete
@tobie tobie added Status: Triage Needs to be verified, categorized, etc Type: Enhancement New feature or request labels Apr 6, 2023
@sidharthv96 sidharthv96 added Contributor needed Status: Approved Is ready to be worked on Good first issue! Type: New Diagram and removed Status: Triage Needs to be verified, categorized, etc labels Apr 22, 2023
@sidharthv96
Copy link
Member

Notes to implementors.

If there are no Points to mark in the chart, the labels of quadrants should come to the center.
I have some doubts on the format for x,y axis labels. start --> end or [start, end]

---
title: Title of chart, will be handled automatically
---

quadrantChart
    x-axis start --> optional end
    y-axis "start with unicode ❤" --> "optional end with unicode ❤"
    quadrant-1 "Label with unicode ❤"
    quadrant-2 Text label
    quadrant-3 Text label
    quadrant-4 Text label

%% section below is optional
    "Point with unicode ❤": [x, y]
    "Point with : colon": [x, y]
    Text point: [x, y]
  • 0 <= (x,y) <= 1
  • x & y axis is optional
  • Axis label ends are optional

We might also need some config values for where to place the axis labels. Sides (top/bottom, left/right) or start&end

Referred some examples at https://psychology.stackexchange.com/questions/22038/what-is-this-type-of-graph-called.

@subhash-halder
Copy link
Contributor

Hi @sidharthv96 I want to take this task can you please assign it to me?

@sidharthv96
Copy link
Member

@amsubhash everyone is free to work on issues without open PRs no need to ask for assignment 😄

@subhash-halder
Copy link
Contributor

Ok got it thanks, will raise a PR as soon as possible

@subhash-halder
Copy link
Contributor

@sidharthv96 I have opened a PR it's in the draft stage, needs to add test cases and update the docs. once complete I will inform you.
can you please assign the issue to me?

@subhash-halder
Copy link
Contributor

subhash-halder commented May 10, 2023

@sidharthv96 @knsv I have implemented the chart, I am thinking first please check the UI and the configuration and finalize them then I can write the docs and the unit/e2e test cases. please let me know how I can proceed.
@sidharthv96 I have made the changes you requested.

@subhash-halder
Copy link
Contributor

@sidharthv96 I Have pushed the changes you suggested along with test cases and documentation, also I have removed it from the draft state.

@sidharthv96
Copy link
Member

sidharthv96 commented Jun 2, 2023

Quadrant chart is available in live editor now!
Thanks for all the great work!

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants