Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly handle unicode when splitting words #4465

Closed
sidharthv96 opened this issue Jun 8, 2023 · 0 comments · Fixed by #4470
Closed

Properly handle unicode when splitting words #4465

sidharthv96 opened this issue Jun 8, 2023 · 0 comments · Fixed by #4470
Labels
Status: Triage Needs to be verified, categorized, etc

Comments

@sidharthv96
Copy link
Member

sidharthv96 commented Jun 8, 2023

  1. Unicode/Emojis. Things like 🤦🏼‍♂️ are a combination of multiple characters. So we can't really use simple slice for the strings as meanings of things might get lost. Non Emoji Unicode combination characters will also have this problem.

  2. Performance. For every single word, we're injecting an SVG into the DOM, removing it, again and again, character by character. So the default example mindmap would mean around 350 additions and 350 deletions into the DOM on a single render. There are programs which render on type, so 700+ DOM operations when the user types a single character. I will tweak the algorithm to only split if necessary.

Originally posted by @sidharthv96 in #4416 (comment)

@github-actions github-actions bot added the Status: Triage Needs to be verified, categorized, etc label Jun 8, 2023
@sidharthv96 sidharthv96 linked a pull request Jun 13, 2023 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Triage Needs to be verified, categorized, etc
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant