Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merged code coverage isn't accurate #4554

Closed
Yokozuna59 opened this issue Jun 27, 2023 · 1 comment · Fixed by #4560
Closed

merged code coverage isn't accurate #4554

Yokozuna59 opened this issue Jun 27, 2023 · 1 comment · Fixed by #4560
Labels
Status: Triage Needs to be verified, categorized, etc Type: Bug / Error Something isn't working or is incorrect

Comments

@Yokozuna59
Copy link
Member

Description

The merged code coverage of vitest and cypress isn't accurate; it's reporting wrong and alternating results. For example, in reports from codecov, if someone updated a file, even if it had no effect on actual code, the coverage percentage would differ. See this PR: #4541 (comment). It shows that the coverage has increased, but the only file that has changed is a github workflow file.

Steps to reproduce

Just merge the code coverage using scripts/coverage.ts script.

Screenshots

No response

Code Sample

No response

Setup

  • Mermaid version: doesn't matter
  • Browser and Version: doesn't matter

Suggested Solutions

The issue is from nyc side, there is an open issue for with some suggested solutions there: istanbuljs/nyc#1302

Additional Context

No response

@Yokozuna59 Yokozuna59 added Status: Triage Needs to be verified, categorized, etc Type: Bug / Error Something isn't working or is incorrect labels Jun 27, 2023
@Yokozuna59
Copy link
Member Author

@sidharthv96 I think we should reopen this issue, the current coverage is 45%:

Coverage Status

https://app.codecov.io/github/mermaid-js/mermaid/commit/194ef202ac5df51056d98c14f13e9ca85f274c35

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Triage Needs to be verified, categorized, etc Type: Bug / Error Something isn't working or is incorrect
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant