Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prevent-inherited-lineheights-on-edgeterminal-4083 #4915

Merged
merged 1 commit into from Nov 25, 2023

Conversation

Patronud
Copy link
Contributor

@Patronud Patronud commented Oct 5, 2023

📑 Summary

A small css fix to prevent line-height from being inherited onto the edgeterminal label.
Preventing labels from appearing trimmed from having a higher line-height than intended.

Resolves #4083

📏 Design Decisions

line-height: initial sets the value back to the default, and has no effect if nothing is written.

📋 Tasks

Make sure you

@netlify
Copy link

netlify bot commented Oct 5, 2023

Deploy Preview for mermaid-js ready!

Name Link
🔨 Latest commit 41c7b08
🔍 Latest deploy log https://app.netlify.com/sites/mermaid-js/deploys/651ed37465a97d0008c10ab3
😎 Deploy Preview https://deploy-preview-4915--mermaid-js.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

Merging #4915 (41c7b08) into develop (1d9ce74) will decrease coverage by 29.73%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##           develop    #4915       +/-   ##
============================================
- Coverage    73.40%   43.67%   -29.73%     
============================================
  Files          136       20      -116     
  Lines        12456     4632     -7824     
  Branches       596       21      -575     
============================================
- Hits          9143     2023     -7120     
+ Misses        3169     2608      -561     
+ Partials       144        1      -143     
Flag Coverage Δ
e2e ?
unit 43.67% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 132 files with indirect coverage changes

@sidharthv96 sidharthv96 merged commit 65ee65b into mermaid-js:develop Nov 25, 2023
17 of 18 checks passed
Copy link

mermaid-bot bot commented Nov 25, 2023

@Patronud, Thank you for the contribution!
You are now eligible for a year of Premium account on MermaidChart.
Sign up with your GitHub account to activate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Labels are trimmed in class diagrams
2 participants