Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: Styling messages and comments separately #60

Closed
MrCoder opened this issue Sep 19, 2023 · 4 comments
Closed

RFC: Styling messages and comments separately #60

MrCoder opened this issue Sep 19, 2023 · 4 comments
Assignees

Comments

@MrCoder
Copy link
Collaborator

MrCoder commented Sep 19, 2023

In our current implementation, we use the following syntax to control the style for both comments and messages. However, it would be good (?) that we could control them separately.

// [red] comments
A.method

The proposed solution:

  1. <red> controls comment only;
  2. (red) controls message only;
  3. [red] controls both comment and message.
@dyon21
Copy link
Collaborator

dyon21 commented Dec 11, 2023

All style brackets should appear before the first non-empty character

@MrCoder
Copy link
Collaborator Author

MrCoder commented Dec 11, 2023

All style brackets should appear before the first non-empty character

Yes. And they should appear only at the last line of comment. Only one type of styling annotation should appear.

Wrong:

// [red] comment
// another line of comment

Wrong:

// <red>(blue) comment

@dyon21
Copy link
Collaborator

dyon21 commented Dec 12, 2023

Why do we not allow multiple annotation types in one comment? Users may want to set different styles to both comments and messages respectively.

@dyon21
Copy link
Collaborator

dyon21 commented Dec 18, 2023

#108

@dyon21 dyon21 closed this as completed Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants