Notes about lock factory

ericmerrill · Nov 18, 2019 · 36a3544 · 36a3544
1 parent 91602f7
commit 36a3544
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/classes/lock_factory.php b/classes/lock_factory.php
@@ -53,7 +53,7 @@ public static function get_lock($resource, $timeout = 10, $maxlifetime = 600) {
             self::$factory = lock_config::get_lock_factory('enrol_lmb');
         }
 
-        // We shouldn't need the prefix, but core poorly defined the API.
+        // We shouldn't need the prefix, but core poorly defined the API. (Fixed in 3.6.7 abd 3.7.3, can remove later.)
         $lock = self::$factory->get_lock('enrol_lmb'.$resource, $timeout, $maxlifetime);
 
         return $lock;

diff --git a/todo.md b/todo.md
@@ -65,3 +65,7 @@ Things to migrate
 * When receiving a new message, like a person, check to see if we need to processes any missed enrollments
 * Possibly track if enrolment was successful in DB like old LMB
 
+
+
+# Future version
+* When 3.7.3 is the lowest supported version, resource can be removed from lock factory (MDL-66935).