Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows Setup uses fixed version #179

Closed
Trenly opened this issue Aug 7, 2023 · 1 comment
Closed

Windows Setup uses fixed version #179

Trenly opened this issue Aug 7, 2023 · 1 comment

Comments

@Trenly
Copy link

Trenly commented Aug 7, 2023

The inno setup script uses a fixed version 2.9.0 as the app version. This writes an incorrect value to the registry when the program is installed and makes it impossible for package managers like winget to detect an upgrade is available. The script should use whatever version is being used for the GitHub release tag

https://github.com/Merrit/nyrna/blob/main/packaging/windows/inno_setup.iss#L3

@Merrit
Copy link
Owner

Merrit commented Aug 7, 2023

Excellent point, thanks for pointing that out!

I will look at automating the version for the next release :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants