Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For Reviewer #21

Open
mershark opened this issue Jul 31, 2023 · 2 comments
Open

For Reviewer #21

mershark opened this issue Jul 31, 2023 · 2 comments

Comments

@mershark
Copy link
Owner

Project url

We are a group of two members

@TedLivist
Copy link

STATUS: CHANGES REQUIRED ♻️ ♻️

Hi @mershark,

Good job so far!
✔️ Kanban columns are complete
✔️ Tasks are complete
However, there are some issues that you still need to work on to go to the next project but you are almost there!

Required Changes ♻️

  • Your tasks are not assigned to anyone. Kindly assign them. If you assign the tasks then they will look like this. I see you have not added your coding partner to the repo. Kindly do that and share the tasks accordingly.

    N.B. For group tasks, you can assign multiple people to a task.

    andre-assigned

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the Issue thread if something is not 100% clear. And please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Issue for re-reviews. You should use the same Issue submitted for the first review, either valid or invalid unless it is requested otherwise.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@muneebulrehman
Copy link

Hi team,

Your project is complete! There is nothing else to say other than... it's time to merge it 🥳
Congratulations! 🎉

Status: Approved✔️

Highlights

  • No linter errors
  • Descriptive PR
  • Good follow-up with the previous reviewer
  • Tasks assigned to each member.

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants