Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use local version of mermaid.min.js #4

Closed
vincentdephily opened this issue Jan 21, 2021 · 3 comments · Fixed by #8
Closed

Use local version of mermaid.min.js #4

vincentdephily opened this issue Jan 21, 2021 · 3 comments · Fixed by #8
Assignees
Labels
enhancement New feature or request

Comments

@vincentdephily
Copy link

The generated html currently fetches mermaid.min.js from a cdn on the internet, which is best practice in some contexts but is I think the wrong default in this case : rustdocs can normally be generated and viewed offline. They should also be impervious to API or url changes 10 years down the road, firewalls, etc.

I think that mermaid.min.js should be saved alongside sidebar-items.js. Not sure if there's a rustdoc naming convention to adhere to (like "cratename.crateversion.normalname") to avoid conflicts with a similar tool.

@mersinvald
Copy link
Owner

Agreed, I'll see how that can be achieved, thanks for the proposal

@mersinvald mersinvald added the enhancement New feature or request label Jan 27, 2021
@mdaj06
Copy link

mdaj06 commented Feb 22, 2021

@mersinvald can i take a look at this? i am pretty new to the Rust ecosystem

@mersinvald
Copy link
Owner

@mdaj06 absolutely, I'll be very grateful if you do :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants