Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problem with cmake rust detection #24

Closed
Chaz6 opened this issue Apr 4, 2019 · 5 comments
Closed

Problem with cmake rust detection #24

Chaz6 opened this issue Apr 4, 2019 · 5 comments

Comments

@Chaz6
Copy link

Chaz6 commented Apr 4, 2019 

-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Cargo Home: /home/chaz/.cargo
-- Rust Compiler Version: rustc 1.33.0
CMake Error at CMakeLists.txt:26 (message):
  Rust is too old, please install at least 1.31 to support the Rust 2018
  edition

The host is running linux 3.10.0-957.5.1.el7.x86_64.
@ymjing
Copy link
Contributor

ymjing commented Apr 4, 2019

Probably a bug in FindRust.cmake. Let me look into this...

@ymjing
Copy link
Contributor

ymjing commented Apr 4, 2019

The "Rust Compiler Version" detected by cmake should be "1.33.0", not "rustc 1.33.0".

@Chaz6 could you share with me the result if you clean the build directory and re-run "cmake .."?

@ymjing ymjing mentioned this issue Apr 4, 2019
Merged
@ymjing
Copy link
Contributor

ymjing commented Apr 4, 2019

@Chaz6 would you mind testing PR #25 ?

@ymjing
Copy link
Contributor

ymjing commented Apr 5, 2019

PR #25 merged. I'm closing this issue.

@ymjing ymjing closed this as completed Apr 5, 2019
@Chaz6
Copy link
Author

Chaz6 commented Apr 7, 2019

Confirmed fixed, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Chaz6 @ymjing