Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix race condition in submit result #671

Closed
NicolasMahe opened this issue Dec 29, 2018 · 0 comments
Closed

Fix race condition in submit result #671

NicolasMahe opened this issue Dec 29, 2018 · 0 comments
Assignees
@krhubert
Labels
bug Something isn't working
Milestone
v0.8

Comments

@NicolasMahe
Copy link
Member

There is a race condition when submitting a result in api/submit_result.go:

https://github.com/mesg-foundation/core/blob/8a0aa00a4912254e38b5747ee20afc881802a2bf/api/submit_result.go#L41-L63

One attempt to fix it has been done in PR #652 but the implementation complexify too much the database.execution api.

@krhubert suggested a better API: #652 (review)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@krhubert krhubert

Labels
bug Something isn't working
Projects
None yet
Milestone
v0.8
Development

No branches or pull requests
2 participants
@krhubert @NicolasMahe