Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor ipfs client + add tests #788

Merged
merged 1 commit into from Feb 17, 2019
Merged

Refactor ipfs client + add tests #788

merged 1 commit into from Feb 17, 2019

Conversation

krhubert
Copy link
Contributor

@krhubert krhubert commented Feb 14, 2019

There was also bug in previous ipfs - resp.Body wasn't close

@krhubert krhubert force-pushed the feature/ipfs-refactor branch 2 times, most recently from ab7dfbe to 56d90cf Compare February 14, 2019 23:52
@krhubert
Copy link
Contributor Author

I think we still have a bug in Add. With every add the content will be diffrent (so the output hash), but it should be the same (like with ipfs add cmd)

➜  multipart go run main.go
--a994c3e69377bf9cfcf39ed913aa9601c9a9fbf308227bb349c278f25f83
Content-Disposition: form-data; name="file"; filename="some-name"
Content-Type: application/octet-stream

x

--a994c3e69377bf9cfcf39ed913aa9601c9a9fbf308227bb349c278f25f83--

QmTP4tQZEG66zwaHPJVuuwaY3P1C3RedqeWjjfzkwdyne7 

➜  multipart go run main.go
--96ea20c35d7fbebd3c06e81b9484483b48349eaf27f1036012be51e1d563
Content-Disposition: form-data; name="file"; filename="some-name"
Content-Type: application/octet-stream

x

--96ea20c35d7fbebd3c06e81b9484483b48349eaf27f1036012be51e1d563--

Qmez8YfputXFtCGoFgTJWcrjRCbv18tta62VW4vUoUzjSy 

@NicolasMahe NicolasMahe merged commit 7c129e8 into dev Feb 17, 2019
@NicolasMahe NicolasMahe deleted the feature/ipfs-refactor branch February 17, 2019 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants