Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

One sid has one hash #839

Merged
merged 1 commit into from Mar 27, 2019
Merged

One sid has one hash #839

merged 1 commit into from Mar 27, 2019

Conversation

antho1404
Copy link
Member

The PR #764 was not completed so the service database had inconsistencies. It was possible to have multiple identical sid in the database also some services were not accessible with the sid after a newest version was delete.

Reverting back to initial behavior which is:
One sid has one hash
One hash belongs to one sid

This will be later changed to
One sid has many hashes
One hash belongs to one sid

Copy link
Contributor

@ilgooz ilgooz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

manual tests are ok

@NicolasMahe NicolasMahe merged commit 77335c5 into dev Mar 27, 2019
@NicolasMahe NicolasMahe deleted the fix/service-database-sid-hash branch March 27, 2019 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants