Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix logs with configuration #880

Merged
merged 3 commits into from Apr 16, 2019
Merged

fix logs with configuration #880

merged 3 commits into from Apr 16, 2019

Conversation

antho1404
Copy link
Member

@antho1404 antho1404 commented Apr 15, 2019 •
edited

Due to the separation of dependencies and configuration, logs were not working anymore.

  • Service logs returns the logs from the config if present
  • CLI ask for the "service" logs when there is no filter (this could be improved with sending nothing and relying on the api)

fix #878

@NicolasMahe NicolasMahe merged commit 6a42f33 into dev Apr 16, 2019
@NicolasMahe NicolasMahe deleted the fix/log-for-config branch April 16, 2019 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krhubert krhubert krhubert approved these changes

@NicolasMahe NicolasMahe NicolasMahe approved these changes

@ilgooz ilgooz ilgooz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Logs not working
4 participants
@antho1404 @krhubert @NicolasMahe @ilgooz