service: simplify DeleteVolumes() #881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilgooz
force-pushed
the
refactoring/service/simplify-deleteVolumes
branch
2 times, most recently
from
806379c
to
6be4e75
Compare
ilgooz
force-pushed
the
refactoring/service/simplify-deleteVolumes
branch
from
6be4e75
to
00d8f65
Compare
* moved Dependency.DeleteVolumes() logic into Service.DeleteVolumes().
ilgooz
force-pushed
the
refactoring/service/simplify-deleteVolumes
branch
from
00d8f65
to
ff141a4
Compare
krhubert
approved these changes
Apr 16, 2019
antho1404
approved these changes
Apr 17, 2019
NicolasMahe
approved these changes
Apr 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to service refactoring #799