service: simplify Status() #885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilgooz
force-pushed
the
refactoring/service/simplify-status
branch
2 times, most recently
from
adb9bbc
to
e9ea6f4
Compare
by moving Dependency.Status() logic into Service.Status(). * removed unneded TestRunningServiceStatus() & TestIntegrationStatusDependency() tests.
ilgooz
force-pushed
the
refactoring/service/simplify-status
branch
from
e9ea6f4
to
a09f146
Compare
krhubert
previously approved these changes
Apr 16, 2019
antho1404
previously approved these changes
Apr 17, 2019
NicolasMahe
previously approved these changes
Apr 17, 2019
ilgooz
dismissed stale reviews from NicolasMahe, antho1404, and krhubert
via
35ac4f9
NicolasMahe
approved these changes
Apr 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.