Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

service: simplify Start() #889

Merged
merged 6 commits into from Apr 19, 2019
Merged

Conversation

ilgooz
Copy link
Contributor

@ilgooz ilgooz commented Apr 17, 2019

No description provided.

* moved Dependency.Start() logic into Service.Start().
* removed unneded TestStartDependency() & TestIntegrationStartDependency() tests.
@ilgooz ilgooz force-pushed the refactoring/service/simplify-start branch from 061beea to 6eb4a35 Compare April 17, 2019 10:37
krhubert
krhubert previously approved these changes Apr 17, 2019
antho1404
antho1404 previously approved these changes Apr 17, 2019
Copy link
Member

@antho1404 antho1404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just added one commit to move the config and shared network outside of the loop

@NicolasMahe NicolasMahe merged commit e5907ae into dev Apr 19, 2019
@NicolasMahe NicolasMahe deleted the refactoring/service/simplify-start branch April 19, 2019 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants