Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace custom pubsub #891

Merged
merged 5 commits into from Apr 19, 2019
Merged

Replace custom pubsub #891

merged 5 commits into from Apr 19, 2019

Conversation

krhubert
Copy link
Contributor

No description provided.

@krhubert krhubert requested a review from ilgooz April 18, 2019 05:58
ilgooz
ilgooz approved these changes Apr 18, 2019
View reviewed changes
Copy link
Contributor

@ilgooz ilgooz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

manual tests are ok

@krhubert krhubert mentioned this pull request Apr 18, 2019
Merged
antho1404
antho1404 reviewed Apr 18, 2019
View reviewed changes
api/api.go Show resolved Hide resolved
@NicolasMahe NicolasMahe merged commit db54fad into dev Apr 19, 2019
@NicolasMahe NicolasMahe deleted the feature/replace-pubsub branch April 19, 2019 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antho1404 antho1404 antho1404 approved these changes

@NicolasMahe NicolasMahe NicolasMahe approved these changes

@ilgooz ilgooz ilgooz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@krhubert @antho1404 @NicolasMahe @ilgooz