Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add goproxy to dockerfile of ethwallet #937

Merged
merged 1 commit into from May 2, 2019
Merged

Add goproxy to dockerfile of ethwallet #937

merged 1 commit into from May 2, 2019

Conversation

NicolasMahe
Copy link
Member

Fix #920

Add a https://proxy.golang.org as goproxy to the dockerfile of etwallet:

ENV GOPROXY=https://proxy.golang.org

@antho1404 does it solve the build?

@NicolasMahe NicolasMahe requested a review from antho1404 May 2, 2019 07:23
antho1404
antho1404 approved these changes May 2, 2019
View reviewed changes
Copy link
Member

@antho1404 antho1404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works well on this branch and still have the issue on the dev :)

@antho1404 antho1404 merged commit 9729b5a into dev May 2, 2019
@antho1404 antho1404 deleted the ss/ethwallet-goproxy branch May 2, 2019 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antho1404 antho1404 antho1404 approved these changes

@krhubert krhubert krhubert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot build ethwallet service
3 participants
@NicolasMahe @antho1404 @krhubert