Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better CI and release process #26

Closed
antho1404 opened this issue Jul 31, 2019 · 4 comments
Closed

Better CI and release process #26

antho1404 opened this issue Jul 31, 2019 · 4 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed @mesg/api Related to @mesg/api @mesg/cli Related to CLI @mesg/compiler Related to @mesg/compiler @mesg/service Related to @mesg/service

Comments

@antho1404
Copy link
Member

I released a version 4.2.1 with the CI and the version was published but without the sources.
The CI should be able to publish with the sources.

The workflow should be the following:

  • Increase version (manually or with npm version)
  • Create a tag with the version
  • Push the tag on Github
  • The CI test the sources
  • The CI build the sources
  • The CI publish the version with the build

After we push on the tags on git we shouldn't have any manual action to do

@antho1404 antho1404 transferred this issue from mesg-foundation/mesg-js Nov 12, 2019
@antho1404 antho1404 added @mesg/api Related to @mesg/api @mesg/application @mesg/cli Related to CLI @mesg/service Related to @mesg/service enhancement New feature or request help wanted Extra attention is needed labels Nov 12, 2019
@NicolasMahe NicolasMahe mentioned this issue Nov 22, 2019
2 tasks
@Roms1383
Copy link
Contributor

Roms1383 commented Dec 1, 2019

I can do it ^^
I already started on the related issue

@Roms1383
Copy link
Contributor

My guess is there's 2 options here :

  1. abide by commit messages convention and get everything automated (using for example commitlint and semantic-release libraries), but that implies that commit messages will have to be carefully written
  2. get more flexibility but less automation by git tagging manually each release, have the CI to parse the tag name and deduct which files to upload to GitHub Release

As of the current state of the project by now I would recommend going for the second approach before considering full automation in the future.

@antho1404
Copy link
Member Author

It seems that lerna has a command lerna version that creates and publishes the tags without publishing on npm. We could use that and then have a standard deploy on npm when there is a new tag. That would follow your second proposition.
Just something to keep in mind (even it shouldn't be a problem), we will have multiple packages in this repository so multiple tags for the different libraries. You can check the existing tags https://github.com/mesg-foundation/js-sdk/releases

@antho1404 antho1404 added the @mesg/compiler Related to @mesg/compiler label Dec 15, 2019
@antho1404 antho1404 added the good first issue Good for newcomers label Jan 23, 2020
@antho1404
Copy link
Member Author

Issue migrated to liteflow-labs/liteflow-js#20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed @mesg/api Related to @mesg/api @mesg/cli Related to CLI @mesg/compiler Related to @mesg/compiler @mesg/service Related to @mesg/service
Projects
None yet
Development

No branches or pull requests

2 participants