Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Add new and modify existing targets in Makefile related to code quality #5

Closed
mgfeller opened this issue Oct 10, 2020 · 7 comments · Fixed by #96
Closed

[CI] Add new and modify existing targets in Makefile related to code quality #5

mgfeller opened this issue Oct 10, 2020 · 7 comments · Fixed by #96
Assignees
Labels
area/ci Continuous integration | Build and release area/tests Testing / quality assurance issue/willfix This issue will be worked on kind/enhancement Improvement in current feature language/go Golang related

Comments

@mgfeller
Copy link
Contributor

Current Behavior

  • Currently, there is no target to fix gofmt and goimport warnings from golangci-lint, and to tidy mod
  • the target running golangci-lintis called check(similar for clearing its cache)
  • Neither is go mod verify executed, and that could be useful too

Desired Behavior

  • Target golangci-run called from target check, or rename check to golangci-run
  • Target clean, executing go clean and golangci-lint cache clean
  • Target verify executing go mod verify
  • Target tidy executing go mod tidy, gofmt -w ., goimports -w .

Resources

Makefiles in other Layer5 (adapter) repositories.

@mgfeller mgfeller added kind/enhancement Improvement in current feature area/ci Continuous integration | Build and release area/tests Testing / quality assurance language/go Golang related labels Oct 10, 2020
@mgfeller mgfeller mentioned this issue Oct 10, 2020
1 task
@mgfeller
Copy link
Contributor Author

mgfeller commented Nov 23, 2020

@kumarabd why was this issue closed? As far as I can see, it has not been implemented.

@kumarabd
Copy link
Contributor

@mgfeller that was my mistake, was going to reopen it.

@mgfeller mgfeller reopened this Nov 24, 2020
@stale
Copy link

stale bot commented Jan 8, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the issue/stale Issue has not had any activity for an extended period of time label Jan 8, 2021
@mgfeller mgfeller added the issue/willfix This issue will be worked on label Jan 9, 2021
@stale stale bot removed the issue/stale Issue has not had any activity for an extended period of time label Jan 9, 2021
@mgfeller
Copy link
Contributor Author

mgfeller commented Jan 9, 2021

I think it could be useful to establish a standard / template (and mark it as such) that we just can copy to the various repositories, to implement this quickly, including the corresponding tool config and entries in the ci workflow. Or do we already have that?
// @ramrodo

@ramrodo
Copy link
Member

ramrodo commented Jan 9, 2021

@mgfeller Sounds great to have a template! There is no template of Makefile for those common tools/targets in the layer5io/layer5-repo-template repo. So, I created this issue in the template repo to track this task and be taken for anyone:
layer5io/layer5-repo-template#9

@mgfeller
Copy link
Contributor Author

@Aisuko which of the existing local checks in the layer5 repos would you recommend as starting point?

@Aisuko
Copy link
Member

Aisuko commented Jan 11, 2021

@Aisuko which of the existing local checks in the layer5 repos would you recommend as starting point?

@mgfeller Thank you, for my personal, I'd like to recommend https://github.com/layer5io/meshsync/blob/v0.1.2/Makefile , but we should replace the golangci.yml, because it was included too many configurations items we did not use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci Continuous integration | Build and release area/tests Testing / quality assurance issue/willfix This issue will be worked on kind/enhancement Improvement in current feature language/go Golang related
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants