Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] Incorporate Adapter Version # at buildtime #188

Closed
mgfeller opened this issue Aug 28, 2021 · 0 comments · Fixed by #189
Closed

[bug] Incorporate Adapter Version # at buildtime #188

mgfeller opened this issue Aug 28, 2021 · 0 comments · Fixed by #189
Assignees
Labels
kind/bug Something isn't working

Comments

@mgfeller
Copy link
Contributor

Description

build-args main.version=$VERSION and main.gitsha=$GIT_COMMITSHA are not being picked up.

Expected Behavior

when testing locally e.g. building using
GOPROXY=direct GOSUMDB=off go build -ldflags="-w -s -X main.version=VERSION -X main.gitsha=GIT_COMMITSHA" -a -o ./meshery-consul .

and running ./meshery-consul

expected result of grpcurl --plaintext 127.0.0.1:10002 meshes.MeshService.ComponentInfo is

{
  "type": "adapter",
  "name": "CONSUL",
  "version": "VERSION",
  "gitSha": "GIT_COMMITSHA"
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant