New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Normalise `model-name to ISTIO` & `model-displayName to Istio` #554

Closed

ayushthe1 wants to merge 1 commit into meshery:master from ayushthe1:smp-enum

Contributor

ayushthe1 commented Mar 6, 2023 •

edited

Description

This PR fixes #548

Notes for Reviewers

model-name has been normalised to ISTIO(smp-enum)
model-displayName has been changed to modelDisplayName
model-displayName has been normalised to Istio (as in integration spreadsheet)

Signed commits

Yes, I signed my commits.


          normalise model:name to ISTIO & model:displayName to Istio

8b8ae67

Signed-off-by: ayush_gitk <ayushsharmaa101@gmail.com>

Contributor

Revolyssup commented Apr 4, 2023

@ayushthe1 Merge conflicts

Contributor Author

ayushthe1 commented Apr 4, 2023

@Revolyssup This has been fixed by #564 .So closing this pr

ayushthe1 closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment