Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] add error codes utility runner workflow #213

Closed
DelusionalOptimist opened this issue Jul 22, 2021 · 4 comments · Fixed by #214
Closed

[CI] add error codes utility runner workflow #213

DelusionalOptimist opened this issue Jul 22, 2021 · 4 comments · Fixed by #214
Assignees
Labels

Comments

@DelusionalOptimist
Copy link
Contributor

DelusionalOptimist commented Jul 22, 2021

Current Behavior

Error codes and their reference is not being updated.

Desired Behavior

Add the error codes updater workflow to update error codes and publish error codes reference

Implementation

  1. Create the error codes updater workflow for the repo. Modify it a bit according to the repository you're working on.
    Sample: https://github.com/layer5io/meshkit/blob/master/.github/workflows/error-codes-updater.yaml
  2. Delete errorutil_analyze_errors.json errorutil_analyze_summary.json errorutil_errors_export.json
  3. Add the three files from previous step to .gitignore
    Sample: https://github.com/layer5io/meshkit/blob/5bc1f9c13e60c7674d8b8c1d8ea434cbb2ce08fd/.gitignore#L21-L23
  4. Also remove them from cache using
    git rm --cached errorutil_analyze_errors.json errorutil_analyze_summary.json errorutil_errors_export.json
  5. Move component_info.json to a helpers directory.
  6. Update command for running utility in Makefile to :
	error:
	go run github.com/layer5io/meshkit/cmd/errorutil -d . analyze -i ./helpers -o ./helpers
@metonymic-smokey
Copy link
Member

@leecalcote
Copy link
Member

Having a look-see at the changes included in the PRs above will be insightful.

@metonymic-smokey
Copy link
Member

Yep @leecalcote , I understood the instructions from those.
Just wanted to notify @DelusionalOptimist to change it in the issue description.

@DelusionalOptimist
Copy link
Contributor Author

@DelusionalOptimist https://github.com/layer5io/meshkit/blob/master/.github/workflows/error-ref-publisher.yaml - this link mentioned above returns a 404 for me

Yeah my bad. Thanks for bringing this up @metonymic-smokey. I've updated the link 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants