Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that the deployed version is covered by the registered components. #449

Closed
leecalcote opened this issue Dec 13, 2022 · 2 comments · Fixed by #469
Closed

Ensure that the deployed version is covered by the registered components. #449

leecalcote opened this issue Dec 13, 2022 · 2 comments · Fixed by #469
Assignees
Labels
kind/bug Something isn't working

Comments

@leecalcote
Copy link
Member

leecalcote commented Dec 13, 2022

Current Behavior

The function used to get latest version of Linkerd inside of build/config.go always returns stable versions and not edge.

Expected Behavior

Replace that with GetLatestReleaseTagsSorted method present in meshkit/utils. And use the last(latest) version returned in the array by the method. This method doesn't prioritize stable and this way the components of all latest versions are registered.

Screenshots/Logs

Environment

  • Host OS: Mac Linux Windows
  • Platform: Docker or Kubernetes
  • Meshery Server Version: stable-v
  • Meshery Client Version: stable-v
  • Meshery Adapter Version: stable-v

Contributor Guides and Resources

@leecalcote leecalcote added the kind/bug Something isn't working label Dec 13, 2022
@stale
Copy link

stale bot commented Jan 27, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the issue/stale Issue has not had any activity for an extended period of time label Jan 27, 2023
@leecalcote
Copy link
Member Author

Another stale issue to address, @Revolyssup. It appears no triaging has been done on this one either.

@stale stale bot removed the issue/stale Issue has not had any activity for an extended period of time label Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants